aurelia / templating-resources

A standard set of behaviors, converters and other resources for use with the Aurelia templating library.
MIT License
59 stars 55 forks source link

Capture and remove matcher binding breaks IE 11 #390

Closed AquilaSands closed 4 years ago

AquilaSands commented 4 years ago

I'm submitting a bug report

Please tell us about your environment:

Current behavior: Commit a5796443016d2c87269dd05801c057fb45e5dc44 introduced a breaking change for IE 11 lines https://github.com/aurelia/templating-resources/blob/d346a817157960d54098a9193fc58c264ceedca6/src/repeat.ts#L289 and https://github.com/aurelia/templating-resources/blob/d346a817157960d54098a9193fc58c264ceedca6/src/repeat.ts#L295 require polyfills for documentFragment.children and documentFragment.firstElementChild respectively.

Without them in my case this caused console errors and the app failed to load. Expected/desired behavior:

bigopon commented 4 years ago

Oops, i checked for IE11 compat without checking for document fragment. My bad. Sorry for this @AquilaSands it would be great if you could send a PR to fix this. Though im not sure what we qould do for this. Polyfill or simple utility fn? Cc @EisenbergEffect @fkleuver