Added generic waitFor and switched existing ones to use this one

aurelia / testing

Simplifies the testing of UI components by providing an elegant, fluent interface for arranging test setups along with a number of runtime debug/test helpers.

MIT License

40 stars 27 forks source link

Added generic waitFor and switched existing ones to use this one #62

Closed konqi closed 6 years ago

konqi commented 7 years ago

In my tests i wanted to supply a custom condition for waitFor. I modified the waitFor so it can handle all kinds of conditions and moved the specifics for query selectors to the respective waitFor functions.

CLAassistant commented 7 years ago

All committers have signed the CLA.

EisenbergEffect commented 7 years ago

@jdanyow Can you review this?

AdamWillden commented 6 years ago

I'm all for this PR although suspect it may be a breaking change?

Docs will need updating too:

http://aurelia.io/hub.html#/doc/article/aurelia/testing/latest/testing-components/8 I've linked to 8 (Helpful Properties and Functions) because link is broken for 9 (Testing complex components)
https://github.com/aurelia/testing/blob/master/doc/article/en-US/testing-components.md#testing-complex-components

konqi commented 6 years ago

I think the docs should be fine - if anything you can do more now. This should also not be a breaking change - it's hard to tell though with so few tests, which is the reason I added some more tests as well.

EisenbergEffect commented 6 years ago

Going to close this PR for now, since we've had some pretty big changes in the core library. If this feature remains still interesting to anyone, please submit a new PR based on master. Also, please try to avoid breaking changes if possible.