aurelia / tools

Tools and utility functions used to build and develop Aurelia's libraries.
MIT License
37 stars 32 forks source link

Add new tasks and expose them via a CLI #51

Open niieani opened 7 years ago

niieani commented 7 years ago

Related to the new build system: https://github.com/aurelia/validation/issues/357

Includes the prepare release task (bump version, changelog).

TODO:

EisenbergEffect commented 7 years ago

Are we good to go on this? It's not going to break anything is it?

niieani commented 7 years ago

It should be a non-breaking change, just adds features. I still wanted to fix that v before the version name when bumping versions/generating changelog though. I was thinking it might make sense to separate the CLI file from the index too.

EisenbergEffect commented 7 years ago

Should I merge this and then take another PR for the other changes or do you just want to fix up this PR?

niieani commented 7 years ago

I'll try to fix this up today. Doesn't make sense to release before we have this working properly.

niieani commented 7 years ago

I sent a PR to standard-version to make that tag prefix configurable and they already released it to NPM. Added TODO to first post.

EisenbergEffect commented 7 years ago

@niieani @jdanyow Is this ready for merge?

niieani commented 7 years ago

TODO from the first post applies. I didn't have time to finish this yet :(. If somebody else wants to do those two tasks, feel free to take over the PR.

EisenbergEffect commented 7 years ago

@jdanyow @niieani Any chance to look at this so we can get it out and start moving more libs to TS?

niieani commented 7 years ago

Best I could do is somewhere in the first half of February.

niieani commented 7 years ago

Looks like this is ready now. If you, @EisenbergEffect, have no more remarks, we can merge and release, we can probably bump to v1.1.0, if not even v2.0.0, just cause we had so many new features (even though we shouldn't be breaking anything).

EisenbergEffect commented 7 years ago

I'd like to see if @jdanyow can make a final review. You two know this better than I do. If you both feel it's good, then I'm happy and we can do a 2.0 release.

StrahilKazlachev commented 7 years ago

@niieani, @jdanyow if you could give some feedback when you have time. So for the past couple of weeks I've been trying to set up the dialog API doc tasks using the cli branch. Problems I've found:

My current working setup uses aurelia-tools, an additional tsconfig.doc.json file and typedoc with the extends fix.

{
  "extends": "./tsconfig.build",
  "compilerOptions": {},
  "include": [
      "./dist/doc-temp/*.d.ts"
  ],
  "exclude": []
}

Part of the npm script for the doc task aurelia-tools typedoc --project tsconfig.build.json. Any suggestions how to further streamline this?

EisenbergEffect commented 6 years ago

Yikes! This has sat here a long time. @niieani @jdanyow Is this something we want to merge or is it no longer valid?

niieani commented 6 years ago

The related https://github.com/TypeStrong/typedoc/pull/436 was unfortunately closed. However, it's possible the feature was added by someone else at a different time. Would need to check.

I'd say this is still a good start for a unified build/release system.

Alexander-Taran commented 6 years ago

seems similar to build targets https://github.com/aurelia/cli/pull/765

EisenbergEffect commented 6 years ago

@jdanyow Do we need this anymore?