search

aurelia / ux

A user experience framework with higher-level capabilities, designed to bring simplicity and elegance to building cross-device, rich experiences.
MIT License
368 stars 55 forks source link

feat(progress): add progress #261

Closed MaximBalaganskiy closed 4 years ago

MaximBalaganskiy commented 4 years ago

Basically a copy of angular's progress spinner

bigopon commented 4 years ago

Please revert the dist files 😬 they ll be taken care by the release process

MaximBalaganskiy commented 4 years ago

Should they be in the repo in the first place? :P

MaximBalaganskiy commented 4 years ago

The way the repo is configured - with the single tsconfig for vscode and build process - it will be inconvenient to not submit dist files, imho. Intellisense relies on those files. I would set two tsconfig files - one, default, for vscode, and another one for build. The one for vscode would have paths configured to alias to src folders. Then you can remove all dist files from the repo.

bigopon commented 4 years ago

Can you help elaborate why a separate tsconfig pointing to source file helps vscode?

MaximBalaganskiy commented 4 years ago

Imagine you just cloned the repo and don't have dist files yet, or just updating the core package and dist files are outdated. Aliasing modules to src folders will fix intellisense issues for vscode. So default tsconfig.json will be a dev config and tsconfig.build.json will be for builds.

With dist files in the repo devs will always have to remember to not push them. Plus, there will be conflicts when pulling.

Also, now I have to rebuild core with each change instead of just edit and enjoy :)

bigopon commented 4 years ago

@MaximBalaganskiy that sounds like a pretty good improvement. Could you help include that in this PR? I'd love it

MaximBalaganskiy commented 4 years ago

Does this look ok?

MaximBalaganskiy commented 4 years ago

Done

bigopon commented 4 years ago

For anyone who wants to have a play/look at the component https://vercel.com/bigopon/aurelia-ux-demo/hb9j8gszp (scroll to bottom)

This looks good to me, so only waiting for @EisenbergEffect 's comment for the .css

MaximBalaganskiy commented 4 years ago

Imports like this have already been used - see input component. https://github.com/aurelia/ux/blob/53224ae6ef2c24ca6f7e09b98fde45381e083a20/packages/input/src/ux-input.ts#L8

EisenbergEffect commented 4 years ago

@bigopon Let's go with this, and then maybe follow-up to see if we can use the same approach throughout the codebase.

bigopon commented 4 years ago

Ok, sounds good then. Let's go