search

aurelia / v1

The Aurelia 1 scaffolding repo used by our tools to setup new projects.
MIT License
9 stars 3 forks source link

Missing option to skip unit testing #9

Closed avrahamcool closed 4 years ago

avrahamcool commented 4 years ago

There in no longer an option for skiping unit testing. [this is also the case when creating a Plugin]

is this by design?

image

3cp commented 4 years ago

Yes, that option is removed to shorten e2e test for this repo.

avrahamcool commented 4 years ago

having to choose a unit test suits adds a lot of dependencies to the project. although testing is important, not all applications use it.

I think this option should be back. (and set the default to "no unit test" - just like before).

3cp commented 4 years ago

Agreed.

avrahamcool commented 4 years ago

@3cp Thank you very much. creating a new project with the "none" option still bring all the test dependencies in the package.json

:(

3cp commented 4 years ago

I only saw aurelia-testing, is that what you mean? The aurelia-testing is also used in dev mode, not just in test, so we cannot remove it.

If you remove it from your project, you need to remove the line in src/main.js too.

avrahamcool commented 4 years ago

You are right.

I've must have made a mistake somehow. sorry for not double checking.