Closed apawsey closed 8 years ago
I'm sorry, I'm really struggling to get this right. At least the commits are separate, so it's easier to see the changes away from the dist changes (I didn't mean to do that, and I tried to undo it, but I think in future I should just learn git away from public eyes).
I have created a gist, but I'm struggling to get it to run... will keep trying. GistRun
@apawsey With 70 files changed you'll need to either backout the ones that aren't relevant (ex dist) or point to the ones that are, that's too many to "peruse" over :)
Closing this for now. We've almost got something ready to do that we believe accounts for all the use cases presented by the community in the issues.
Take 2... smaller PR with just the actual changed code... original PR message below... busy putting together a gist of the sample app.
Ok I know this is probably totally in poor taste, or against some ethics of git which I'm not really aware of... so my apologies, this was just one of those things where I wanted to have a play, and it all just got away from me. At this point it's just to initiate discussion, feedback etc.
So the run down...
Like I said, this is just a big experiment for me. Pushing this as a PR is also not a good idea, but I didn't really know how to point anyone to my fork. I'd like any honest feedback on the +/- of this approach.
Oh and as @EisenbergEffect said he doesn't like inheritance, I doubt this will do anything to change hid mind :tired_face: