search

aurelia / validatejs

Enables expressive validation using decorators and/or a fluent API.
MIT License
22 stars 23 forks source link

Type hints and documentation for #10 #69

Closed derkork closed 8 years ago

derkork commented 8 years ago

I have added type hints and documentation in order to fix issue #10. Please let me know if this is ok this way or if some changes are required. Thanks.

plwalters commented 8 years ago

Awesome I'll take a look at this and get it merged in ASAP - have you signed the CLA yet?

derkork commented 8 years ago

Yes I have signed the CLA before sending the pull request. Thanks for having a look at it.

2016-05-25 23:27 GMT+02:00 Patrick Walters notifications@github.com:

Awesome I'll take a look at this and get it merged in ASAP - have you signed the CLA yet?

— You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub https://github.com/aurelia/validatejs/pull/69#issuecomment-221712875

EisenbergEffect commented 8 years ago

@derkork There appear to be changes. Would you be willing to rebase on master? @jdanyow has some work that's going to be committed soon. It might be best to wait until he has that in. @jdanyow Can you ping @derkork here when he can rebase to add the types and api comments?

derkork commented 8 years ago

I see. Well just ping me when you're ready I'll rebase the branch then.

EisenbergEffect commented 8 years ago

@derkork Can you take a look now?

derkork commented 8 years ago

I'm on vacation currently, but I'll try to squeeze it in next week.

2016-06-29 16:32 GMT+02:00 Rob Eisenberg notifications@github.com:

@derkork https://github.com/derkork Can you take a look now?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aurelia/validatejs/pull/69#issuecomment-229374576, or mute the thread https://github.com/notifications/unsubscribe/AAT-WVhhtQVm5eJ31XSNcK3l6y_IXzlsks5qQoIFgaJpZM4ImNGK .

EisenbergEffect commented 8 years ago

@derkork Hope you had a nice vacation. Just wanted to check in and see if you would have time this week to update this PR. Thanks!

EisenbergEffect commented 8 years ago

Ok, closing this PR for now. If you have time, please re-submit based on master. Thank you!