search

aurelia / validation

A validation plugin for Aurelia.
MIT License
132 stars 129 forks source link

Add types to support .d.ts file generation #244

Closed plwalters closed 8 years ago

plwalters commented 8 years ago

Need these so that the aurelia-validatejs lib can generate it's own without failing

Reference https://github.com/aurelia/validatejs/issues/10

jrigsby commented 8 years ago

With validation released to alpha yesterday. I wanted to try testing it out but I use typescript in visual studio 2015 via gulp. The other day I followed a project that fixed aurelia rtypings by editing typings.json and went to do the same for aurelia-validation and aurelia-valdiatejs. For validation I tried using

"aurelia-validation": "github:aurelia/validation/dist/aurelia-validation.d.ts#e52e1c80866b14165d8407fdd87a0aeb73151131"

this is a guess as to how to get the path and I could be wrong but when executing typings install I get

"Attempted to compile "aurelia-validation" as a global module, but it looks like an external module."

Is this related or am I doing something wrong in trying to get typings? Its alpha so not expecting things to work in every use case but would like to "watch" something to know when I can.

WorldMaker commented 8 years ago

@jrigsby That error means that aurelia-validation should be in dependencies rather than globalDependencies in typings.json.

jrigsby commented 8 years ago

Okay thank you, then Ill make the change and try to get it to work.

jdanyow commented 8 years ago

@jrigsby are you all set now?

jrigsby commented 8 years ago

As far as typescript and building files goes yes. Thanks.

On Jun 15, 2016, at 11:07 PM, Jeremy Danyow notifications@github.com<mailto:notifications@github.com> wrote:

@jrigsbyhttps://github.com/jrigsby are you all set now?

You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/aurelia/validation/issues/244#issuecomment-226377159, or mute the threadhttps://github.com/notifications/unsubscribe/ANr2KuEH47DCkB2mMmywLoVujmK0P4Ucks5qML3SgaJpZM4IhbLa.