aurelia / validation

A validation plugin for Aurelia.
MIT License
132 stars 128 forks source link

chore: dropped circleci in favor of GH workflow #579

Closed Sayan751 closed 1 year ago

Sayan751 commented 1 year ago

@bigopon Can you please take a look at this. I am not sure what happens with the publishing to npm. Is that still a manual process? A naive way to automate this would be to add a pipeline step

- run: npm publish
  env:
    NODE_AUTH_TOKEN: ${{secrets.AUTH_TOKEN_NEEDED_FOR_PUBLISHING_TO_NPM}}
bigopon commented 1 year ago

I have not had good experience with the old publish setup, sometimes things broke and it's confusing to fix. Also it's unclear what's being run and what rules to follow. Maybe we can use some tool to manage, or at the very least, do things the manual but clear way. I'll do manual first, like many of our other repos, which is way easier to deal with.

Sayan751 commented 1 year ago

@bigopon I have removed the npm publish step.