search

aurelia / webpack-plugin

A plugin for webpack that enables bundling Aurelia applications.
MIT License
90 stars 36 forks source link

Incompatible with ts-loader transpileOnly mode. #126

Closed RichiCoder1 closed 2 years ago

RichiCoder1 commented 6 years ago

I'm submitting a bug report

Please tell us about your environment:

Current behavior: Using Aurelia/Typescript with the ts-loader option transpileOnly: true set will will result in errors similiar to the Aurelia PAL not properly loading. In my specific case, a custom element isn't properly getting it's Element injected.

I'm using transpileOnly (and alternatively happy pack mode) to speed up builds a little.

jods4 commented 6 years ago

My first instinct would be to redirect this to ts-loader folks...

transpileOnly is supposed to speed up compilation by not doing type checking, but the resulting JS code should be exactly the same. Turning this on or off should have no visible effect (other than muting TS errors).

If you sift through issues, it wouldn't be the first time transpileOnly has bugs that changes the output.

Aurelia plugins have no code specific to ts-loader, you could use raw JS, Coffeescript or whatever you like, as long as the output of your loader is good JS.

Alexander-Taran commented 2 years ago

@bigopon let's close this