Closed silbinarywolf closed 5 years ago
All this changes seem reasonable to me! I'll work on actioning this within the next few days!
Thanks for the feedback :)
Seems like it's not really possible to update the wiki with a PR, as per: https://stackoverflow.com/a/11481887/5013410
I have however, put up a branch here with the copy change: https://github.com/silbinarywolf/aurelia-webpack-plugin-wiki/pull/1
A maintainer will need to merge this in by pulling it down manually.
@jods4 Let me know if the above changes are all OK or if they need further effort :)
LGTM. I will update the wiki once this is published.
@EisenbergEffect It's all ready :)
@jods4 Want to take a final look or are we ready to merge?
@EisenbergEffect LGTM
fix(webpack): remove runtime insertion hack from webpack 3 or below era, wherein only the first "entry" item had the runtime appended to it.
This was originally implemented to avoid adding the runtime to the secondary "vendor" entry. Using "vendor" entry points which is no longer recommended for Webpack 4 and up.
Fixes #157