aurelia / webpack-plugin

A plugin for webpack that enables bundling Aurelia applications.
MIT License
90 stars 36 forks source link

v2.0 #88

Closed niieani closed 7 years ago

niieani commented 7 years ago

PR for @jods4 new version of the module.

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

jods4 commented 7 years ago

@EisenbergEffect Not sure why the CLA assistant is unhappy?

EisenbergEffect commented 7 years ago

Probably different emails associated with the PR.

On Jan 31, 2017 2:07 AM, "jods" notifications@github.com wrote:

@EisenbergEffect https://github.com/EisenbergEffect Not sure why the CLA assistant is unhappy?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aurelia/webpack-plugin/pull/88#issuecomment-276323424, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIBnfqBO4brbdLhBbLCGCf8I3CRrZZcks5rXwf9gaJpZM4LwiMG .

niieani commented 7 years ago

@EisenbergEffect any ETA on merging and releasing updates to dependent packages (like PAL, webpack-loader and bootstrapper)? As long as other packages are ready, I think we can merge this and proceed publicly with the new skeleton. If you're afraid of breaking something we could do major bumps with a beta tag for a grace period until we ensure everything works before we switch to stable.

How does that sound to you?

EisenbergEffect commented 7 years ago

@jods4 Is this all ready to merge and release?

jods4 commented 7 years ago

@EisenbergEffect You might want to merge and publish #90 first, it's a patch for the previous webpack plugins.

But then yes, this is what early adopters are currently testing so merging and publishing a pre-release 2.0.0-rc.1 on NPM is OK.

It would be nice if you could merge and publish the Aurelia PRs that are related to webpack, aurelia/framework#710 and aurelia/binding#569 are still open.

EisenbergEffect commented 7 years ago

I'm working through all the PRs now from oldest to newest, so I'll definitely get those. Thanks!

jods4 commented 7 years ago

I rebased this branch because of the #90 merge.

niieani commented 7 years ago

@jods4 I think a bit too soon, @EisenbergEffect still needs to release that one, no? ;) That'll add one more commit to the master history before this can be merged and released as v2.

EisenbergEffect commented 7 years ago

Yes, I still need to release 1.x. I can do that today or tomorrow.

RichiCoder1 commented 7 years ago

Random internet person curious what's left for this to merge :)

EisenbergEffect commented 7 years ago

Lots of releases of dependencies 😁 Going to start pushing those out over the next week.

On Feb 14, 2017 2:22 PM, "Richard Simpson" notifications@github.com wrote:

Random internet person curious what's left for this to merge :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aurelia/webpack-plugin/pull/88#issuecomment-279855338, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIBnakK-1VPjt313nORIrk0oPDOm_-Sks5rcikbgaJpZM4LwiMG .

RichiCoder1 commented 7 years ago

Excellent! Excited to refactor :)

gregoryagu commented 7 years ago

I, too, am looking forward to the V2 release. Is this close to being released?

jods4 commented 7 years ago

Aurelia update is close to release, it will integrate some changes that make webpack consumption easier.

The v2.0 webpack plugins will be released slightly later but after the Aurelia release I would say there's nothing preventing you from taking a dependency on this branch directly if you don't want to wait.

gregoryagu commented 7 years ago

I notice that Aurelia Framework 1.1 was released a few days ago. Is this the update that should work with V2 of the Webpack plugin? In other words, can I go ahead and start using this?

jods4 commented 7 years ago

@gregoryagu yes, the roll-out of Aurelia packages is in progress. Not every package has been published yet, I guess Rob will do a blog post when he's done all of them.

EisenbergEffect commented 7 years ago

@jods4 Can you fix the conflicts here?

jods4 commented 7 years ago

@EisenbergEffect I rebased the changes so that there's no conflict anymore.