search

aurelia / webpack-plugin

A plugin for webpack that enables bundling Aurelia applications.
MIT License
90 stars 36 forks source link

fix "Can't resolve 'bundle'" issue #90

Closed jinwangchina closed 7 years ago

CLAassistant commented 7 years ago

CLA assistant check
All committers have signed the CLA.

jods4 commented 7 years ago

Thanks for this submission, webpack 2.0 does indeed need -loader by default, this is a breaking change from webpack 1.0.

As we are close to publishing a complete rewrite of the plugins for webpack 2.2 anyway, I'm not sure if we want to merge that PR or skip it.... @niieani ?

niieani commented 7 years ago

@EisenbergEffect If we want to publish the old webpack-plugin as 1.2.1 (with this PR) and the new one as 2.0.0-beta at the same time (in two steps) then I'd be down with merging this too.

EisenbergEffect commented 7 years ago

Ok, just to make sure I understand the plan. You want me to merge this and then make a 1.x release. Then merge #88 and make the 2.x release. Is that correct?

niieani commented 7 years ago

@EisenbergEffect this would be ideal, yes, since it's a bug-fix for those running the v1 stack. But if it's too much work, we can also just focus on providing v2 ASAP and getting all those affected migrated.

EisenbergEffect commented 7 years ago

It's no problem. I just wanted to make sire I did the right thing.

On Feb 5, 2017 2:33 AM, "Bazyli Brzóska" notifications@github.com wrote:

@EisenbergEffect https://github.com/EisenbergEffect this would be ideal, yes, since it's a bug-fix for those running the v1 stack. But if it's too much work, we can also just focus on providing v2 ASAP and getting all those affected migrated.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/aurelia/webpack-plugin/pull/90#issuecomment-277510077, or mute the thread https://github.com/notifications/unsubscribe-auth/AAIBncVLDkZeLtGe_2oKtHMPjomUgzgVks5rZaVmgaJpZM4LzeXN .