search

aureliendavid / rsspreview

WebExtension to preview RSS feeds in the browser
MIT License
103 stars 6 forks source link

Content displayed twice (due to union select on feed item content?) #14

Closed be-vol closed 5 years ago

be-vol commented 5 years ago

Hi, I appreciate the work on this extension but I noticed one difference to the origin display of Firefox. A feed I use very frequently (Jira activities feed) makes use of the <summary> and the <content> element. But unfortunately the content of <summary> is only a shortened version of <content>. With the rsspreview extension I now see all the content twice. I guess its because of the used union select in the XSL template: <xsl:copy-of select="description | atom:summary | atom:content | rss1:description" />

In FF before version 64 I didn't had that problem. Maybe Firefox had implemented some logic like only use atom:content if atom:summary is not present or empty?

aureliendavid commented 5 years ago

good catch

so what would be the preferred behavior in case both elements are present? which one should we display?

I'm guessing <summary> is better for a preview page? (and <content> would be better for a full fledged reader)

be-vol commented 5 years ago

Yes, I think that would be a good approach.

aureliendavid commented 5 years ago

alright I'll do that thanks for the report

aureliendavid commented 5 years ago

should be done in v2.4 on AMO

close the issue if resolved

thanks

alok1111 commented 5 years ago

I guess it is not solved. Tried v2.6 and on this page https://www.onliner.by/feed I still see 2 images. Downgrade to 2.2 solved the problem.

aureliendavid commented 5 years ago

https://www.onliner.by/feed I still see 2 images

ok this is a different issue

in v2.5 I added the display of media:thumbnail images but some feed repeat the thumbnail image in the content/description of the entry

issue #12 talks about this, I suggest closing this one and continuing on this subject over there

if you downgrade manually you can use v2.4 which contains the fix for the original issue here but not the thumbnails

aureliendavid commented 5 years ago

@alok1111 : you can use the latest version (v2.7) which has thumbnails disabled by default

I'm closing this issue since the original issue is fixed, discussion about thumbnails continues on #12