search

aureliendavid / rsspreview

WebExtension to preview RSS feeds in the browser
MIT License
99 stars 6 forks source link

Error on certain feed #15

Closed nanaya closed 5 years ago

nanaya commented 5 years ago

Sample feed.

Not quite sure what's happening here:

TypeError: "feed_desc is null"
    formatsubtitle moz-extension://5cdbef52-a731-48c6-83db-c66609b730ea/rsspreview.js:56:1
    main moz-extension://5cdbef52-a731-48c6-83db-c66609b730ea/rsspreview.js:287:7
    onload moz-extension://5cdbef52-a731-48c6-83db-c66609b730ea/rsspreview.js:28:11

Looks like the xsl failed? Due to unrecognized xmlns?

aureliendavid commented 5 years ago

Hi @nanaya,

Indeed the xslt didn't apply because this is an Atom 0.3 feed, and the namespace url is different from Atom 1.0

(xmlns="http://purl.org/atom/ns#" in this feed, and xmlns="http://www.w3.org/2005/Atom" for Atom 1.0)

Even though the element names are the same, xsl doesn't recognize them as the same namespace since the url if different.

So I added support for atom 0.3 explicitly to the xsl stylesheet (which is starting to get ugly but eh).

It should work with v2.8, please test and close the issue if it's resolved.

Thanks for the report.

nanaya commented 5 years ago

Thanks, it works now.