aureliendavid / rsspreview

WebExtension to preview RSS feeds in the browser
MIT License
103 stars 6 forks source link

RSSPreview compatibility with Waterfox #21

Closed grahamperrin closed 5 years ago

grahamperrin commented 5 years ago

https://addons.mozilla.org/addon/rsspreview/versions/ 3.1, for example:

Works with android 48.0 and later, firefox 42.0 and later

– but there's no detection, and the UI to preferences does not work:

image

Waterfox 56.2.6 on FreeBSD-CURRENT (Waterfox 56.0 was based on Firefox 56.0.2).

I guess that you should add a strict_min_version to manifest.json.

aureliendavid commented 5 years ago

I don't know what the minimum version on which it works is, but prior to firefox 64 everything that RSSPreview does was done natively by firefox so it's kind of irrelevant I guess?

grahamperrin commented 5 years ago

… kind of irrelevant I guess?

Yes and no :-)

With Waterfox-compatible Awesome RSS enabled, I get (for example) the option to subscribe to a feed whilst at this page. If I disable the extension there's no longer the visual hint.

aureliendavid commented 5 years ago

but without any addon you can right-click the toolbar > customize and add the "Subscribe" button to the toolbar to get the same feature no?

but I do agree that rsspreview isn't working with this version, i'll try to find the min compatible version and add it to the manifest

grahamperrin commented 5 years ago

LOL at myself,

customize

I have customised hundreds of times over the years and been blind to the Subscribe button!

(Maybe because the first thing that I do with any new profile is remove superfluous default items – that's nearly everything – from the toolbar and menu, to make way for more useful items that are not integral to the browser. My mindset probably became: items that are hidden by default must be doubly superfluous … completely ignorant to them.)