search

aureliendavid / rsspreview

WebExtension to preview RSS feeds in the browser
MIT License
99 stars 6 forks source link

Could not you use the activeTab permission? #22

Closed rugk closed 5 years ago

rugk commented 5 years ago

I doubt you really need permission for <all urls>, i.e. all sites, should not activeTab work, too?

IMHO it's good to reduce the permissions.

aureliendavid commented 5 years ago

that's a good point, I'll check if it's sufficient

I'm all for restricting permissions.

aureliendavid commented 5 years ago

it looks like we do need <all urls> for the background script's content-type "trick"

(we change content-types like application/rss+xml to text/xml to force firefox to display the document instead of opening a download dialog)

rugk commented 5 years ago

Okay, so closing?

aureliendavid commented 5 years ago

I guess yeah, thanks for the suggestion though