search

aureliendavid / rsspreview

WebExtension to preview RSS feeds in the browser
MIT License
103 stars 6 forks source link

Use browser language for language-dependent content #47

Closed jtotht closed 4 years ago

jtotht commented 4 years ago

Currently getlang() returns the user’s desired page language used on websites. I think it should rather use the language of the browser itself (as it’s more part of the browser UI), i.e., getlang’s body should be changed to

return browser.i18n.getUILanguage();

(or maybe simply substituted everywhere). Documentation on MDN.

aureliendavid commented 4 years ago

thanks for the info, it makes sense to me

i'll include it in the next release

jonafato commented 4 years ago

@aureliendavid looks like this is in master and just waiting on a release? Should this issue be closed?

aureliendavid commented 4 years ago

yeah I was waiting to have other stuff to include to upload a release on AMO but I kinda forgot about it

let's keep the issue open to remind me to do it. I can't right now but I should have some time tomorrow

aureliendavid commented 4 years ago

this is now included in release v3.12.1