aurelienpierreeng / ansel

A darktable fork minus the bloat plus some design vision.
https://ansel.photos
GNU General Public License v3.0
682 stars 21 forks source link

Tone EQ: merge advanced and masking tabs #134

Open pedrorrodriguez opened 1 year ago

pedrorrodriguez commented 1 year ago

Using this module is cumbersome because functionality that should be together is separated into advanced and masking tabs. I suggest we merge them and get rid of the grey bar indicator in the masking tab.

tone eq-merged

Also, is there a use case for the simple view? If not, perhaps it can be removed as well.

EDIT: there is, since it's the only way to bind node adjustment to keyboard shortcuts.

AlynxZhou commented 1 year ago

I personally uses advanced tab everyday.

pedrorrodriguez commented 12 months ago

Also, perhaps the curve smoothing can be adjusted via scrollwheel on the graph (like denoise profiled and contrast equalizer) instead of via dedicated slider

wilecoyote2015 commented 3 months ago

I strongly agree with this request. Due to the different ranges of individual images, I have to switch between the tabs for almost every image. Further consideration: Tuning of t maks postprocessing parameters would be significantly simpler if the historgram in the graph could be seen, which would be a nice side effect of merging the tabs