Stars rating keyboard shortcut not functioning

[Dave22152]

I understand that you're revamping the stars rating approach. Your forked version (as of 3.9.0+1781~gb8cdc71b6-dirty on Windows 11) seems to have disabled the keyboard shortcut for ratings. For example, I select an image and type a "3" then a message will pop-up stating "3 not applied". I don't know if this is intentional, but the keyboard shortcut was a bit of a time saver. Good luck with your efforts!

[jorgesate]

That happend to me even in (main) darktable. I just needed to remap every number again to make it work.

Hope this gets you around, at least.

[Dave22152]

Thanks!

Dave G.

Sent from my iPhone

On Jun 28, 2022, at 3:11 AM, jorgesate @.***> wrote:

 That happend to me even in (main) darktable. I just needed to remap every number again to make it work.

Hope this gets you around, at least.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

[aurelienpierre]

Fixed ?

[Dave22152]

I recreated the shortcuts on my machine, but without any changes to the code then I’d expect that the original problem still persists. I can try with a fresh build when I get back home in a couple of weeks.

Dave G.

Sent from my iPhone

On Jul 17, 2022, at 4:31 PM, Aurélien PIERRE @.***> wrote:

 Fixed ?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

[aurelienpierre]

That's one of the perks of the new MIDI shit. Previously, keyboard shortcuts used Gtk accelerators. Now, that got replaced by something custom. Gtk identifies numeric keys the same, whether they are input from numpad or text pad. The new stuff doesn't. That's progress.

[Dave22152]

I can see how new interfaces could mess with legacy keyboard actions. The shortcuts do work under DT 4.0, which made me consider that something changed under your fork.

Reassigning the shortcut is a viable workaround, but the question of the missing shortcuts has already come up in the forum and I’d expect more confusion unless the functionality is restored in the program or at least addressed in documentation.

Sent from my iPhone

On Jul 21, 2022, at 6:01 AM, Aurélien PIERRE @.***> wrote:

 That's one of the perks of the new MIDI shit. Previously, keyboard shortcuts used Gtk accelerators. Now, that got replaced by something custom. Gtk identifies numeric keys the same, whether they are input from numpad or text pad. The new stuff doesn't. That's progress.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

[dterrahe]

Gtk identifies numeric keys the same, whether they are input from numpad or text pad. The new stuff doesn't. That's progress.

For those who extensively use keyboard shortcuts, the ability to assign numpad keys separately from the "ordinary" number keys is indeed progress. The old behavior can "easily" be restored by explicitly recreating the double mapping. This could also be made the default. Gtk helpfully, when asked for a text representation of a key, doesn't make a distinction between "1" and "1", so as shown in the screenshot above, the double mappings do looks confusing/redundant.

That's one of the perks of the new MIDI shit. Previously, keyboard shortcuts used Gtk accelerators.

Input NG (lovingly referred to as "the MIDI shit" by some, but having a somewhat wider goal which made continuing with the "something custom" previously arduously layered on top of Gtk accelerators infeasible and actually allowed a large cleanup in that area) still uses Gtk to translate the old-style default shortcut declarations to the new key specific definitions. Somewhere between this landing in master 1.5 years ago and now, it seems a gtk update broke this on windows (ah,... dependencies).

At least, that is what must have happened because otherwise it would be hard to imagine that this only gets reported as an issue now, and only in a github fork that is slightly less than welcoming to a subset of developers. In fact, a large amount of time was spent during design and development to try to avoid regressions for all, but given the platform, language and hardware specific issues that can crop up in this area, such an endeavor can only succeed when feedback, explicitly asked many times at all stages of the process, is provided by the community. And feedback can be something besides just criticism of the non-constructive kind.

[aurelienpierre]

For those who extensively use keyboard shortcuts, the ability to assign numpad keys separately from the "ordinary" number keys is indeed progress. The old behavior can "easily" be restored by explicitly recreating the double mapping.

The fact that a "4" works differently depending on where it's typed is a regression, period. Otherwise, we wouldn't label keys on keyboards, we would just use their coordinates.

This kind of comment makes me very happy to not have to deal with your bullshit anymore. Keep developing headless libraries, don't mess up with UX.

[Dave22152]

Fixed ?

I just build a fresh (Windows) copy and the short cuts are still missing. Like I said earlier, remapping the key stroke is a good work around, so I suggest closing the issue if you don't see it as a priority.

[dterrahe]

https://github.com/darktable-org/darktable/pull/12351

[aurelienpierre]

Anyway, I need to make numeric keys behave the same for the whole keyboard. The current behaviour is unacceptable and breaks a very basic user expectation for the sake of allowing deviant niche uses from a bunch of dudes who spend more time reading config files than editing actual pictures.

It is expected that users who don't want the numpad to behave as a numpad hit the num_lock key. That is, for the rest of the world who work with computers instead of for computers.

[aurelienpierre]

Fixed.

[Dave22152]

Great, thanks!

Dave G.

From: Aurélien PIERRE @.> Sent: Thursday, January 19, 2023 8:43 PM To: aurelienpierreeng/ansel @.> Cc: Dave22152 @.>; Author @.> Subject: Re: [aurelienpierreeng/ansel] Stars rating keyboard shortcut not functioning (Issue #8)

Fixed.

— Reply to this email directly, view it on GitHub https://github.com/aurelienpierreeng/ansel/issues/8#issuecomment-1397824065 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AOSRY6VRHRC2W4CCBRSNPLTWTHURHANCNFSM5ZZLI4YQ . You are receiving this because you authored the thread. https://github.com/notifications/beacon/AOSRY6U6BE5POGG5AFWS6UDWTHURHA5CNFSM5ZZLI4Y2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOKNIRUQI.gif Message ID: @. @.> >

[aurelienpierre]

I just went one step further today. All numpad events will be simple remapped to regular key strokes. Enter will be enter no matter where you type it, numbers will just be numbers, etc.

You know, like in any application. 🙄

[Dave22152]

Well, that’s excellent and thanks again.

On a side note, given that you’re off the PIXLS site is there a place where people can ask you questions concerning your modules?

Dave G.

From: Aurélien PIERRE @.> Sent: Friday, January 20, 2023 9:55 AM To: aurelienpierreeng/ansel @.> Cc: Dave22152 @.>; Author @.> Subject: Re: [aurelienpierreeng/ansel] Stars rating keyboard shortcut not functioning (Issue #8)

I just went one step further today. All numpad events will be simple remapped to regular key strokes. Enter will be enter no matter where you type it, numbers will just be numbers, etc.

You know, like in any application. 🙄

— Reply to this email directly, view it on GitHub https://github.com/aurelienpierreeng/ansel/issues/8#issuecomment-1398502206 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AOSRY6WLG7R7IL26J6LHPNDWTKRNHANCNFSM5ZZLI4YQ . You are receiving this because you authored the thread. https://githubcom/notifications/beacon/AOSRY6QYVKSTX7UCRPGA4F3WTKRNHA5CNFSM5ZZLI4Y2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOKNNXGPQ.gif Message ID: @. @.> >

[aurelienpierre]

Yes : https://photo.aurelienpierre.com/private-lessons-on-retouching-with-darktable/?lang=en

[nitschis]

Is this broken again with the newest release?

I don't have numpad and I have already tried resetting the star shortcuts, but no matter what I do, stars a not set with my number keys.