search

auremoser / sg-events

[project] study group events pull
2 stars 5 forks source link

Improvement Ideas & Questions #7

Open lvyachao opened 7 years ago

lvyachao commented 7 years ago

For CRAWLER Part Code:

  1. Old node-github library doesn't support "getContent"-like function so there are two libraries combined to get content. Potential Solution: New node-github library(and some other libraries) support this function now: https://mikedeboer.github.io/node-github/#api-repos-getContent Octokat may not necessary
  2. We use another "Combine" python code manually generate a combined json file. Questions: Why we include a small function in nodeJS code to generated a combined Json file everytime we finish crawler job but leverage a Python code.
  3. Is a "Timer"-like script needed -- to make this function fully automatically after deployed. Most simple way is that we deploy a server and let it run script every XX days. It helps while it also may not necessary. Anyway, it's easy.
lvyachao commented 7 years ago

@auremoser Pls check when you have time, THX!!!!

auremoser commented 7 years ago

Is a "Timer"-like script needed -- to make this function fully automatically after deployed. Most simple way is that we deploy a server and let it run script every XX days. It helps while it also may not necessary. Anyway, it's easy.

Not necessarily, I was thinking of running the script(s) monthly to collect new events. Automation might be nice, but running it manually will help me keep track of activities, so I'm not opposed to that.

Thanks for looking at the other scripts and outlining a process @lvyachao !