Closed pamarcos closed 6 years ago
Thanks, that looks good. I must admit I don't have much time to test in details, but the code looked quite fine to me, hopefully that can help people
@pamarcos The definition for "isRpath" seems to be missing, see #32
Shame on me, I had some extra stuff to help me debug and I did not include that chunk by mistake using git add -p
. Apologies, but it's already fixed in https://github.com/auriamg/macdylibbundler/pull/33
Current version of dylibbundler does not support rpath references in libraries. Consider the following example:
Then, running the current version of
dylibbundler
:Even though the
test
binary does include one rpath directory:This change aims to add support for such rpath references. It basically collects all rpaths using
otool -l
and looking forLC_RPATH
in each dependency. Then, whenever there is an@rpath
, it tries to look for that file in all rpaths collected.In the previous given example, this the the dependencies for the resulting binary when running
dylibbundler -od -b -x test -d libs -p @executable_path/libs
:I did a little refactoring to avoid code duplication and tried to adapt to the current code style. I'm all ears for any kind of change that may be needed, so feedback is welcome.