Closed pamarcos closed 6 years ago
Thank you, its' now merged
Great! I just saw that Travis is already working. However, it seems the GITHUB_TOKEN
thing is not in place yet. It would be cool to have it so that people can download the latest of master from the Release section of the project 😄
https://travis-ci.org/auriamg/macdylibbundler/builds/367896400
Actually, I have prepared GITHUB_TOKEN, so not quite sure why it's not working. I don't really have the time to diagnose this right now though
I see, so the build was probably done due to the merge but before you set up the GITHUB_TOKEN
.
Since Travis CI is triggered with a new push, it should work either with the next change or if you restart the build or trigger a new build manually.
After I missed the 'isRpath' definition in a previous PR I thought it would be a good idea to have Travis CI set up for this project so that it does not happen again. Travis provides a Continuous Integration system for free for open source projects that runs a script to build the solution for every single time you push. That's extremely convenient, especially for pull requests, since it validates that at least the work builds correctly.
I did create the![image](https://user-images.githubusercontent.com/3248441/38852737-47dad188-421b-11e8-9efb-5756d7ebad0e.png)
.travis.yml
file with the configuration, but you will need to enable Travis for your repo by signing in into https://travis-ci.org/ with your Github account and enabling from your profile page:You can see the results of the Travis' build in my fork: https://travis-ci.org/pamarcos/macdylibbundler/builds/367499989
I even added a fancy
upload.sh
script to upload the resulting binary to your repo's release page so that everyone can download the latest. You can check how it looks here: https://github.com/pamarcos/macdylibbundler/releasesIn case it's a PR instead of a branch where you pushed, it will simply be sent to https://transfer.sh so that you can easily download and test it without building it yourself.
For this
upload.sh
script to work properly, you need to create aGITHUB_TOKEN
in GitHub and pass it to Travis CI as an environment variable.Display value in build log
is unchecked (it is unchecked by default) to prevent leaking your token to everyone since the build logs are public.Let me know if you need any more help to set it up. If you don't find it useful, you can freely cherry-pick commit 8056cb70ae5fa4011ef64293cff60b1df18bc3f8
PS. This is my way of apologizing for not committing all the needed chunks in https://github.com/auriamg/macdylibbundler/pull/31 😃