search

auriamg / macdylibbundler

Utility to ease bundling libraries into executables for OSX
MIT License
550 stars 83 forks source link

Fix failing build by adding missing include #35

Closed metalicjames closed 6 years ago

metalicjames commented 6 years ago

The current version from master fails to build with clang on Ubuntu 18.04. limits.h is not being included. This a regression introduced by #31 .

clang++ -O2 -c -I./src ./src/Settings.cpp -o ./Settings.o
clang++ -O2 -c -I./src ./src/DylibBundler.cpp -o ./DylibBundler.o
./src/DylibBundler.cpp:112:17: error: use of undeclared identifier 'PATH_MAX'
    char buffer[PATH_MAX];
                ^
1 error generated.
Makefile:8: recipe for target 'dylibbundler' failed
make: *** [dylibbundler] Error 1
auriamg commented 6 years ago

I am not sure why you're trying to build a mac-only tool on Ubuntu?

metalicjames commented 6 years ago

I use it to package Mac binaries that I have cross-compiled from Linux (and it works great!).

auriamg commented 6 years ago

Alright, seems like a rare use case but harmless to merge