search

auriamg / macdylibbundler

Utility to ease bundling libraries into executables for OSX
MIT License
546 stars 83 forks source link

Regression somewhere after 9cf053f8b399512e12d7931fa24f466057e58044 #47

Closed maxmitti closed 3 years ago

maxmitti commented 4 years ago

As you can see, the build with 9cf053f8b399512e12d7931fa24f466057e58044 works fine, whereas with the current master it asks for manual path input and times out eventually.

SCG82 commented 4 years ago

Can you try with PR #48?

git fetch origin pull/48/head:fix-map
git checkout fix-map
maxmitti commented 4 years ago

Does not seem to help, unfortunately: https://travis-ci.org/legacyclonk/LegacyClonk/builds/632032359#L1298

SCG82 commented 4 years ago

Can you try using my fork https://github.com/SCG82/macdylibbundler and run dylibbundler with the following args:

macdylibbundler/dylibbundler -q -cd -a clonk.app
maxmitti commented 4 years ago

Yes, that succeeds: https://travis-ci.org/legacyclonk/LegacyClonk/jobs/632080435#L1304 However, I haven't tested yet if the created bundle actually works.

SCG82 commented 3 years ago

@maxmitti Can you try with PR #60?

git clone https://github.com/auriamg/macdylibbundler
cd macdylibbundler
git fetch origin pull/60/head:resolve_loader_path
git checkout resolve_loader_path
make
cd ..
macdylibbundler/dylibbundler -od -b -x clonk.app/Contents/MacOS/clonk -d clonk.app/Contents/libs/
maxmitti commented 3 years ago

I am not sure whether you are allowed to see this, but something does not work. However, it could be a usage issue on my side. LegacyClonk no longer uses macdylibbundler for the builds, so I just branched from an old branch which used to use it and adjusted it slightly without remembering why it is set up the way it is.

SCG82 commented 3 years ago

61 fixes this. Thanks!