search

auriamg / macdylibbundler

Utility to ease bundling libraries into executables for OSX
MIT License
546 stars 83 forks source link

Can't build dylibbundler - missing PATH_MAX #57

Closed WhiteElephantGmbH closed 3 years ago

WhiteElephantGmbH commented 3 years ago

Hi, Using Catalina. make fails because PATH_MAX is not defined. It doesn't seem to be defined in any of the sources, so I guess this is some sort of system constant that make, on my system, is failing to find. What is the recommended solution?

auriamg commented 3 years ago

Hi, unfortunately I do not have access to a computer running Catalina so I am unable to assist myself. If someone finds a solution, however, pull requests are welcome

SCG82 commented 3 years ago

It builds just fine for me on Catalina 10.15.7. Which version of XCode do you have installed? What's the output of: c++ -v xcode-select -p xcrun --show-sdk-path

WhiteElephantGmbH commented 3 years ago

Hi,

I am running Catalina 10.15.7 but I have the same problem on my BigSur 11.2.1 machine

Under Catalina c++ - v produces

Apple clang version 12.0.0 (clang-1200.0.32.29) Target: x86_64-apple-darwin19.6.0 Thread model: posix InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

Xcode-select -p produces /Applications/Xcode.app/Contents/Developer

And xcrun --show-sdk-path produces /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk

Best wishes, Ahlan

On 16 Mar 2021, at 08:40, SCG82 @.***> wrote:

It builds just fine for me on Catalina 10.15.7. Which version of XCode do you have installed? What's the output of: c++ -v xcode-select -p xcrun --show-sdk-path

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/auriamg/macdylibbundler/issues/57#issuecomment-800030860, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKT3FUFEICBJ4647LYEHC7LTD4DQNANCNFSM4ZGCEOAA.

SCG82 commented 3 years ago

Can you try with PR #58?

git fetch origin pull/58/head:cpp11
git checkout cpp11

then run

make clean && make

https://github.com/auriamg/macdylibbundler/blob/e1e5dc6a28fccf9f8f7bd2ff051ac927dd3cea48/src/DylibBundler.cpp#L31 defines PATH_MAX.

WhiteElephantGmbH commented 3 years ago

Excellent! This fixes the problem. :-) I can now build dylibbundler on both Catalina and BigSur.

Many thanks & best wishes, Ahlan

On 16 Mar 2021, at 15:40, SCG82 @.***> wrote:

Can you try with PR #58 https://github.com/auriamg/macdylibbundler/pull/58?

git fetch origin pull/58/head:cpp11 git checkout cpp11 then run

make clean && make

https://github.com/auriamg/macdylibbundler/blob/e1e5dc6a28fccf9f8f7bd2ff051ac927dd3cea48/src/DylibBundler.cpp#L31 https://github.com/auriamg/macdylibbundler/blob/e1e5dc6a28fccf9f8f7bd2ff051ac927dd3cea48/src/DylibBundler.cpp#L31 defines PATH_MAX.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/auriamg/macdylibbundler/issues/57#issuecomment-800316632, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKT3FUCXZJCA5462PMF6N4TTD5UU7ANCNFSM4ZGCEOAA.