search

aurilisdev / Electrodynamics

Electrodynamics is a mod that brings realistic, world-based science and technology into Minecraft along with some other additions.
https://aurilis.dev/electrodynamics/
Other
72 stars 19 forks source link

Fluid and gas pipe throughput limit not respected in practice #273

Closed 9thCore closed 1 month ago

9thCore commented 3 months ago

Despite being described with specific throughput rates, neither fluid or gas pipes respect that and output as much as possible, all the time. (not shown in video, but also happens with gas pipes)

Repro:

  1. Place down any fluid source leading into a pipe
  2. Place down pipes leading to a tank
  3. Watch as the tank does not get filled in increments of 5k/10k (as per pipe restriction) only
  4. Repeat experiment with gasses

Rather unscientific video (shows only the fluid part of the issue, but gasses play the same): https://github.com/user-attachments/assets/536c01da-2a74-4b9e-9454-2d8053188d19

Slightly more scientific proof: The only use of AbstractNetwork#networkMaxTransfer (related to fluids and gasses) is the commented-out snippet in FluidNetwork, and no use in GasNetwork. In the same vein, neither is IAbstractCable#getMaxTransfer used anywhere except for calculating AbstractNetwork#networkMaxTransfer.

Technical data: Minecraft 1.20.1 Forge 47.3.1 Electrodynamics 1.20.1-0.9.1-0

skiprocks999 commented 1 month ago

kekw I forgot to re-implement that when I was doing the pumps. Good catch.