search

aurimasv / zotero

https://zotero.org
Other
1 stars 1 forks source link

[COinS export]: Avoid exporting editors, translators, etc. #27

Closed zuphilip closed 9 years ago

zuphilip commented 9 years ago

Discussed at https://forums.zotero.org/discussion/50880/every-contributor-exported-as-author-in-coins-export/#Item_0

This affects the COinS export as well as the OpenUrl resolving.

zuphilip commented 9 years ago

Please have a look at new version.

adam3smith commented 9 years ago

I think getting rid of the special treatment for first authors is fine. I spend some time reading through the NISO OpenURL standard and they don't give any rationale for it, but my guess would be that it's an odd side-result from the XML version of the standard, where aulast and aufirst are allowed for every author (since they're part of a single <author> node, there's no risk of confusion there). Instead of taking this out of the context object version entirely, they left it in for the first author.

zuphilip commented 9 years ago

Are you suggesting to use au and aucorp only? And not using aufirst and aulast at all, but seperating them by comma as suggested above? Your hypothesis sounds reasonable, also it may be a little speculative. Then, the condition that aucorp can occur at most once would be an error (since years), right?

adam3smith commented 9 years ago

yes exactly. I was reacting to the comments inline here: https://github.com/aurimasv/zotero/pull/27#discussion_r36057860 they're all collapsed now, so a bit hard to keep track of.

I'm unsure about what to do about aucorp -- I do think it's a mistake in the spec (potentially related to the same XML issue I speculate about above), but I'm also hesitant to do something that clearly violates the written specs. Do we lose anything by just using au?

aurimasv commented 9 years ago

Do we lose anything by just using au?

Besides clear directions to treat author as an institutional author, I don't think so. I think that's currently the safest choice and one that makes the most semantic sense.

zuphilip commented 9 years ago

I updated the PR. Please have a look at the new version.

aurimasv commented 9 years ago

Do you want to move that block I commented on out of the loop? I can do it after merge otherwise. Either way, squash please.

zuphilip commented 9 years ago

The block you mentioned is moved out of the loop (sorry, I forgot before). The commits are squashed.

aurimasv commented 9 years ago

Thanks! Now just need to write tests. Will probably take me a couple days to get to this.