search

aurora-is-near / aurora-engine

⚙️ Aurora Engine implements an Ethereum Virtual Machine (EVM) on the NEAR Protocol.
https://doc.aurora.dev/develop/compat/evm
322 stars 78 forks source link

Mutative methods on Non-mutative section #376

Open mfornet opened 2 years ago

mfornet commented 2 years ago

Methods on the wasm engine interface are divided in those that mutate the state, and those that don't mutate the state.

There are methods (like ft_transfer) that mutates the state, but is in the non mutative section.

mrLSD commented 2 years ago

@mfornet when you mentioned MUTATIVE & NONMUTATIVE state section, you mean just grouping of methods after comments for an example:

    ///
    /// MUTATIVE METHODS
    ///

If it's true, ft_trasfer is in the BENCHMARKING METHODS section. Am I clear that issue about regrouping methods to correct comment sections?

mfornet commented 2 years ago

Am I clear that issue about regrouping methods to correct comment sections?

Yes, exactly this. This is only about putting the method in the section they belong. Maybe we should consider adding a section for NEP141 Standard implementation methods.

joshuajbouw commented 2 years ago

NEP-141 section is fine.