A bug was found where we increment the nonce when a user is OutOfFund. After looking into it, there were some other areas where the nonce could be incremented incorrectly. As far as I can tell, with these changes, this shouldn't affect internal services, but that needs to be checked ideally by @birchmd.
Performance / NEAR gas cost considerations
No gas increases, though a slight reduction should be possible.
Testing
Tests were updated for this fix.
How should this be reviewed
While the fix should be correct, it should be checked that this is fine for internal services.
Description
A bug was found where we increment the nonce when a user is
OutOfFund
. After looking into it, there were some other areas where the nonce could be incremented incorrectly. As far as I can tell, with these changes, this shouldn't affect internal services, but that needs to be checked ideally by @birchmd.Performance / NEAR gas cost considerations
No gas increases, though a slight reduction should be possible.
Testing
Tests were updated for this fix.
How should this be reviewed
While the fix should be correct, it should be checked that this is fine for internal services.