aurora-is-near / aurora-engine

⚙️ Aurora Engine implements an Ethereum Virtual Machine (EVM) on the NEAR Protocol.
https://doc.aurora.dev/develop/compat/evm
330 stars 82 forks source link

fix: incremented nonce on out of fund failure #671

Closed joshuajbouw closed 1 year ago

joshuajbouw commented 1 year ago

Description

A bug was found where we increment the nonce when a user is OutOfFund. After looking into it, there were some other areas where the nonce could be incremented incorrectly. As far as I can tell, with these changes, this shouldn't affect internal services, but that needs to be checked ideally by @birchmd.

Performance / NEAR gas cost considerations

No gas increases, though a slight reduction should be possible.

Testing

Tests were updated for this fix.

How should this be reviewed

While the fix should be correct, it should be checked that this is fine for internal services.

aleksuss commented 1 year ago

@joshuajbouw take a look, please.