search

aurora-is-near / aurora-engine

⚙️ Aurora Engine implements an Ethereum Virtual Machine (EVM) on the NEAR Protocol.
https://doc.aurora.dev/develop/compat/evm
330 stars 82 forks source link

Fix: register_relayer() Functionality is Unnecessary #731

Closed lempire123 closed 1 year ago

lempire123 commented 1 year ago

It is unnecessary to require relayers to register an EVM address before they can receive fees for deposits.

The function register_relayer() allows a user to register an EVM address that receives fees from the bridge. Fees are paid to an EVM address so a relayer must have an associated EVM address to receive funds.

However, since near_account_to_evm_address()provides a default mapping from a NEAR AccountId to an EVM address it is possible to allow relayers to receive funds without first registering an EVM address.

Aurora-ClickUp commented 1 year ago

Task linked: CU-85zrqmerc AUR-32 register_relayer() Functionality is Unnecessary

mrLSD commented 1 year ago

Related to #607 relayer will not receive fee at all. And some related logic was also deleted.

@lempire123 pls fix the tests. CI failed.

lempire123 commented 1 year ago

Related to #607 relayer will not receive fee at all. And some related logic was also deleted.

@lempire123 pls fix the tests. CI failed.

I guess there's no point in fixing this specific report then, given the auditors weren't aware that the NEP-141 logic would be separated?