search

aurora-is-near / aurora-engine

⚙️ Aurora Engine implements an Ethereum Virtual Machine (EVM) on the NEAR Protocol.
https://doc.aurora.dev/develop/compat/evm
330 stars 82 forks source link

chore: use owner account in engine authorizer #736

Closed aleksuss closed 1 year ago

aleksuss commented 1 year ago

Description

The PR allows using an owner account in the EngineAuthorizer rather than a hardcoded aurora account.

Performance / NEAR gas cost considerations

There should be no changes in the performance.

vimpunk commented 1 year ago

There is no performance impact despite reading from storage because this is a read only method, correct?

aleksuss commented 1 year ago

I guess you mean increasing gas costs? I think it increases gas costs a bit, even if this is a read-only operation because read-only ops are not free. But we don't have to worry about that because it's a rare operation (pause_precompiles). What we do care about are submit and call and their inner functions, which work with storage.