aurora-is-near / aurora-engine

⚙️ Aurora Engine implements an Ethereum Virtual Machine (EVM) on the NEAR Protocol.
https://doc.aurora.dev/develop/compat/evm
325 stars 78 forks source link

Fix(modexp): re-enable Aurora implementation #811

Closed birchmd closed 1 year ago

birchmd commented 1 year ago

Description

With the improvements from #809 merged, we can start using the Aurora implementation of modexp.

Performance / NEAR gas cost considerations

There is a gas cost increase in one of the repro tests. This must mean the ibig implementation of modexp is faster for the case used in that transaction. But using the Aurora implementation of modexp is still an improvement because the worst-case performance of the Aurora implementation is better than ibig, as exemplified in the bench_modexp_standalone test.

Testing

Existing tests.

aleksuss commented 1 year ago

I believe that the ibig dependency could be optional now?