`engine-modexp` bug fixes and performance improvements with unusual exponents - Githubissues

aurora-is-near / aurora-engine

⚙️ Aurora Engine implements an Ethereum Virtual Machine (EVM) on the NEAR Protocol.

https://doc.aurora.dev/develop/compat/evm

325 stars 78 forks source link

`engine-modexp` bug fixes and performance improvements with unusual exponents #814

Closed guidovranken closed 1 year ago

guidovranken commented 1 year ago

Description

Fixes a panic with empty exponent
Ensure correct result with zero exponent
Fix performance issues with exponents with large zero padding

Performance / NEAR gas cost considerations

The performance is increased for some cases (those with exponents with a large amount of leading zeroes) and remains the same for all other cases.

Testing

Fuzzing and tests added.

How should this be reviewed

Additional information