search

aurora-is-near / rainbow-bridge-client

Monorepo containing Aurora-maintained libraries for using the Rainbow Bridge
https://github.com/near/rainbow-bridge-client/tree/main/packages/client#readme
MIT License
25 stars 7 forks source link

getBalance is not a generic ERC20 metadata #49

Open 0x3bfc opened 3 years ago

0x3bfc commented 3 years ago

The user's balance is user centric metadata. It should be used outside the getErc20Data.

https://github.com/aurora-is-near/rainbow-bridge-client/blob/f1039b490da07915b94b84056b22c00ff3aef01b/packages/nep141-erc20/src/natural-erc20/getMetadata.js#L72

and getBalance should be exported here:

https://github.com/aurora-is-near/rainbow-bridge-client/blob/f1039b490da07915b94b84056b22c00ff3aef01b/packages/nep141-erc20/src/natural-erc20/getMetadata.js#L5