search

aurora-is-near / rainbow-bridge-client

Monorepo containing Aurora-maintained libraries for using the Rainbow Bridge
https://github.com/near/rainbow-bridge-client/tree/main/packages/client#readme
MIT License
25 stars 7 forks source link

fix: user get balance #50

Closed 0x3bfc closed 3 years ago

0x3bfc commented 3 years ago

closes #49

0x3bfc commented 3 years ago

can you address failing CI

Yeah sure

paouvrard commented 3 years ago

Should we move getBalance to getBalance.js then since it is not metadata ? and rename getErc20Data to getMetadata? For some context, I think getErc20Data grouped everything together as a convenience to the rainbow-bridge-frontend, https://github.com/aurora-is-near/rainbow-bridge-frontend/blob/06ca162327e16288b389b8ee28843a48d22edecd/src/js/utils.js#L18 but since getAllowance was also added separately, it makes send to refactor it.

paouvrard commented 3 years ago

I think we can close this PR because the library is now using ethers and I will be making this refactor in this PR: https://github.com/aurora-is-near/rainbow-bridge-client/pull/58

0x3bfc commented 3 years ago

I think we can close this PR because the library is now using ethers and I will be making this refactor in this PR: #58

Please close it if you feel that it doesn't add to main branch or the refactor you have in the PR #58 :)