search

aurora-is-near / rainbow-bridge-client

Monorepo containing Aurora-maintained libraries for using the Rainbow Bridge
https://github.com/near/rainbow-bridge-client/tree/main/packages/client#readme
MIT License
25 stars 7 forks source link

style: rename transfer steps #8

Closed paouvrard closed 3 years ago

paouvrard commented 3 years ago

https://hackmd.io/wKy5TKXxQqGvQVIiOdVdUg In case of Near -> Ethereum transfer back, these 2 steps can also be improved (and combined ?)

alexauroradev commented 3 years ago

Agree.

  • ‘Await NEAR finality for withdrawal transaction’ Maybe remove this step at all? It happens in 2 sec max. Comparing to the next step it's nothing. Also, 3 steps is better than 4.
  • ‘Sync withdrawal transaction to Ethereum’ Maybe change this into 'Wait for withdrawal confirmation on Ethereum (up to 17 hours)'.

Also, the amount of confirmations (Ethereum -> NEAR) and the waiting period in the above step is variable and may change in the future. For sure the numbers are different for different deployments (we need to allow for this).

The best option would be to have an endpoint from the relayers where FE can query an estimate for how long a use should wait. I'll create a separate issue for this: #9.

chadoh commented 3 years ago

‘Await NEAR finality for withdrawal transaction’

Maybe remove this step at all? It happens in 2 sec max. Comparing to the next step it's nothing. Also, 3 steps is better than 4.

I'll leave it to @paouvrard whether to implement this or not, but I want to give some context for why a separate step was initially included here.

Each step shown in the UI corresponds to a separate, asynchronous step in the transfer process. Meaning that once there's withdraw data to check ("Convert X to Y"), there's no blocking and waiting for new blocks to be created to get subsequent information.

withdraw / checkWithdraw functionality is quite complicated. Complicating it even more to block and wait for the finality block to be created will complicate it even more.

From a communicating-to-the-user perspective, I also kind of like having this here. It tells advanced users (most of the users of this app?) that NEAR has finality. And it make it feel like NEAR is fast, while the "waiting for Ethereum" part is long 😄