aurora-multiphysics / VacuumMesher

Implementing mesh skinning functionality within libMesh, as well as the generation of the vaccum Mesh (The area surrounding a meshed geometry).
2 stars 1 forks source link

Fixed Cubic boundary generation. #20

Closed TheBEllis closed 1 month ago

TheBEllis commented 1 month ago

Cubic Boundaries When using --boundary_type Cube, previously the BoundaryGenerator::genBoundary() method was calling BoundaryGenerator::genSquare(), which returns only the edges (boundary elements) of a square. Importantly, the square was NOT being tessellated yet, so the resulting boundary was completely invalid. Now BoundaryGenerator::genTriangulatedSquare has been added, #18 should be fixed.

Bounding Box Boundaries Previous to this PR BoundaryGenerator::genBoundingBoxBoundary() could wrongly set the boundary mesh subdivisions to 0 on one of the 3 axes if the structure being vacuum meshes is much thinner in one dimension. Now a minimum of 2 subdivisions is enforced in all axes to ensure a valid mesh is generated.