search

aurora-opensource / streetscape.gl

Visualization framework for autonomy and robotics data encoded in XVIZ
http://www.streetscape.gl
MIT License
914 stars 222 forks source link

[proposal] remove streambuffer in child class. #525

Closed SlahserZ closed 2 years ago

SlahserZ commented 2 years ago

I'm rebuilding this project by ts, and found a problem.

in XVIZLoader, you could use streambuffer which be from child class by context switch. but it's so loose.

so I think we can put the streambuffer into XVIZLoader and remove streambuffer in child class. if you ac this, I will fix it.

twojtasz commented 2 years ago

what do you mean rebuilding in TS? You are rewriting the whole thing in TS. I have some ts defs. would be great to coordinate.

SlahserZ commented 2 years ago

what do you mean rebuilding in TS? You are rewriting the whole thing in TS. I have some ts defs. would be great to coordinate.

yes, I have rebuild myself project by typescript, but found @xviz/xxx is heavier than my mind, so sorry, I have given this plan up.