search

aurora-opensource / streetscape.gl

Visualization framework for autonomy and robotics data encoded in XVIZ
http://www.streetscape.gl
MIT License
923 stars 222 forks source link

Points are not rendered! #535

Closed JunkyDeveloper closed 2 years ago

JunkyDeveloper commented 2 years ago

Hi, i currently testing with the example kitti dataset. and i had checked out the master branch and all are rendered but not the lidar points. In version 1.0.9 (tag) primitive points working but on the source code on the master they aren't rendered!

Was there a change or is that a bug?

twojtasz commented 2 years ago

let me try to verify

twojtasz commented 2 years ago

i don't have any issues

twojtasz commented 2 years ago

I was finally able to verify this and fix it.

The problem is that the hosted date for our demo on the website uses a color format for points of RGBA, where generating data with newer XVIZ libs will produce RGB (though details depend on the calling code).

The problem was that the PointCloudLayer in Deck.gl >= 8.0 has a prop colorFormat that defaults to RGBA. This results in a GL_INVALID error when we have 3 component color/RGA.

I just published 1.0.13, which should fix the issue.