aurora / rmate

Remote TextMate 2 implemented as shell script
GNU General Public License v3.0
886 stars 123 forks source link

fixed: file perms and ownership nuked on save #2

Closed paulgrav closed 12 years ago

paulgrav commented 12 years ago

Hi,

Firstly thanks for writing rmate.sh, works great. However I noticed an issue where a file that I was editing would have its perms set from 775 to 644 on save.

I’ve written a tiny fix for this. It seems to work fine and preserves the ownership and perms of the files that I edit.

aurora commented 12 years ago

hi paul,

thanks very much for the fix. i've applied it right now. i am glad, that my script is useful :)

kind regards,

harald

2012/1/4 Paul Grave reply@reply.github.com:

Hi,

Firstly thanks for writing rmate.sh, works great.  However I noticed an issue where a file that I was editing would have its perms set from 775 to 644 on save.

I’ve written a tiny fix for this.  It seems to work fine and preserves the ownership and perms of the files that I edit.

You can merge this Pull Request by running:

 git pull https://github.com/paulgrav/rmate perms-fix

Or you can view, comment on it, or merge it online at:

 https://github.com/aurora/rmate/pull/2

-- Commit Summary --

  • fixed: file perms and ownership nuked on save

-- File Changes --

M rmate.sh (3)

-- Patch Links --

 https://github.com/aurora/rmate/pull/2.patch  https://github.com/aurora/rmate/pull/2.diff


Reply to this email directly or view it on GitHub: https://github.com/aurora/rmate/pull/2

http://www.pixelio.de/ Deine kostenlose Bilddatenbank für lizenzfreie Fotos

paulgrav commented 12 years ago

Awesome. Glad to help.

Yeah, like you perhaps, I can’t (nor do I want to) go installing Ruby on all the various servers that we have at work. So your dependency-light script is great. Don’t know why the Textmate guys went down the Ruby instead of a simple bash script. Oh well...