aurora / rmate

Remote TextMate 2 implemented as shell script
GNU General Public License v3.0
887 stars 123 forks source link

Implemented ability to open a folder #44

Closed KES777 closed 6 years ago

KES777 commented 8 years ago

https://github.com/henrikpersson/rsub/issues/37

aurora commented 8 years ago

Thanks for your patch! I've always rejected this feature in the past because i think you can easily do this already in combination with other commands like find. Anyway ... i leave this open and play around with it ... maybe i'll change my mind! :wink:

KES777 commented 8 years ago

oh, you can replace my code by line using find =). I use linux under 10 years and I do not know how to use find. I need to google, read some article ... ((( it is too hard vs: rsub dir/

ghost commented 8 years ago

This is how to open many files in a folder in many tabs in SublimeText. But how to open a folder, like subl . command?

KES777 commented 8 years ago

@ginolon : yes, that is interesting feature. but not supported yet. There is bounty Join ;-)

ickc commented 6 years ago

This line is not safe: for dir in `ls $filepath` ; do. e.g. use find ... -exec or find ... -print0 | xargs -0 ... instead.

aurora commented 6 years ago

I am closing this pull request, as there's a merge-conflict currently anyway. Also i think the functionality should be implemented using features of the current rmate version (using the open_file function rather than spawning additional rmate processes). I have some ideas regarding this and am working on an own patch to support this now.