search

aurora / rmate

Remote TextMate 2 implemented as shell script
GNU General Public License v3.0
887 stars 123 forks source link

add support for connecting via UNIX socket #66

Open aurora opened 6 years ago

aurora commented 6 years ago

See https://github.com/aurora/rmate/pull/63 for details. This get's implemented by supporting a generic proxy-command that can be optionally specified as command-line argument or configured in the settings file.

aurora commented 6 years ago

@jordemort is it ok to bother you with more questions on this? :-) First of all, i would like to add your little perl proxy to this repository, is it ok to add a GPL-3 license header (same license as rmate?). If yes, i would add the following to the perl proxy script:

#
# (c) copyright 2017-2018 Jordan Webb
# 
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 3 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program.  If not, see <http://www.gnu.org/licenses/>.
#
jordemort commented 6 years ago

Yes, that's fine with me

hadisfr commented 6 years ago

It seems there are still some undone works and unix-socket has not been merged to master till now.

What should be done to make it ready? 🤔 Is https://github.com/aurora/rmate/pull/63#issuecomment-356314775 done?

aurora commented 6 years ago

I think it's still unfinished 😄 ... seems i really didn't have much time for this all, this year ... the plan was to make jordemort's patch a generic solution, where the proxy-command is configurable.

aurora commented 5 years ago

first "generic-proxy command" commit: 85cecaf363f242f6165a7e9d692ce81a716711e7

aurora commented 5 years ago

@jordemort i think i've got it working with the generic proxy-command, if you have time and would like to give it a try (the proxy-command branch). I am a little unhappy about my config-parser, because it would be more logic to put the proxy-command in quotes, so i have to probably improve the config-parser, next ...

@hadisfr you've updated the README in the past with information regarding sublime-text - i've already added documentation regarding this new feature to the README, but i am only familiar with TextMate. Would you be willing to give the proxy-command a try and updated the README for sublime-text, if necessary?