search

aurora / rmate

Remote TextMate 2 implemented as shell script
GNU General Public License v3.0
887 stars 123 forks source link

Flags specified after the file-to-open are ignored #73

Closed fake-name closed 5 years ago

fake-name commented 5 years ago 
durr@testcnc:~$ rmate /usr/lib/tcltk/linuxcnc/bin/halshow.tcl
File /usr/lib/tcltk/linuxcnc/bin/halshow.tcl is not writable! Use -f to open anyway.
durr@testcnc:~$ rmate /usr/lib/tcltk/linuxcnc/bin/halshow.tcl -f
File /usr/lib/tcltk/linuxcnc/bin/halshow.tcl is not writable! Use -f to open anyway.
durr@testcnc:~$ rmate -f /usr/lib/tcltk/linuxcnc/bin/halshow.tcl
< file opens >

For shell commands, I generally assume that flags can go anywhere. However, rmate seems to only parse arguments rmate <here> filename.

This is, well, certainly unexpected, if not a huge issue. It'd be nice if arguments to rmate behaved like every other well-behaved command-line tool.

aurora commented 5 years ago

Mmmm ... thanks for the suggestion, i'll have a look into this.

aurora commented 5 years ago

I've created a branch for this and i think i fixed it - could you give it a try?

aurora commented 5 years ago

I've merged this into the master branch, because i think it's fixed now.

fake-name commented 5 years ago

Cool! Sorry, I haven't had a chance to poke at it yet.