search

aurora / rmate

Remote TextMate 2 implemented as shell script
GNU General Public License v3.0
887 stars 123 forks source link

Change error and new window behaviors #76

Closed jnooree closed 4 years ago

jnooree commented 4 years ago

Hello,

I'm using rmate with sublime text 3 and rsub plugin. I don't use textmate, so I'm not sure the original script works well with textmate or not.

However, when using with sublime, it couldn't open multiple files but just one of them (the first one). So I added the functionality to this program, basically by wrapping up things into a new function.

https://github.com/jnooree/rmate/blob/809f8e237bd1be34079da1d9067de68054681f68/rmate#L408-L432

Again, I'm not a textmate user, so this commit might have conflicts with textmate. Sorry for this. By the way, thank you for this utility. You almost saved my life!

jnooree commented 4 years ago

I'm sorry for mistake. This issue was partially resolved in RemoteSubl. However, I think it would be better to warn the files that are not writeable and open others, rather than refusing to open all the remaining files (current behavior).

I'll make another commit shortly.

aurora commented 4 years ago

However, I think it would be better to warn the files that are not writeable and open others, rather than refusing to open all the remaining files (current behavior).

Sounds reasonable - thanks for your pull-request. I'll have a closer look at it as soon as possible and will merge it, if i have no objections.

aurora commented 4 years ago

Looks good to me - will just do some minor changes later (for code-consistency reasons). Thanks for your help!