search

aurowallet / auro-wallet-browser-extension

Mina Protocol browser extension wallet
https://www.aurowallet.com
Apache License 2.0
44 stars 25 forks source link

Mnemonic Phrase mismatch between display and confirmation #24

Closed xendarboh closed 1 year ago

xendarboh commented 1 year ago

In chrome browser (Linux) with fresh install of Auro Wallet extension, during setup there can be a mismatch of phrase words between the "Backup Mnemonic Phrase" display and the following confirmation step requiring input to proceed.

This occurs after waiting on the first display screen for a certain amount of time, for example the time it takes to manually write down the words. (A separate issue, is that floating windows of the wallet will disappear upon mouse re-focus, so can't use another application on the same computer to record the phrase.)

This does not occur if more quickly proceeding from backup to confirmation screens. Not sure if it will occur every time, but with waiting between steps, I could reproduce the issue multiple times.

For example, this "display" step: image

and this "confirmation" step: image

wjdfx commented 1 year ago

Thanks for your feedback. We aware It's a bug cause Manifest V3. Will fix this at next version.

SvenMeyer commented 1 year ago

@wjdfx This is a SEVERE problem ! What if somebody saves the wrong seed words, has to restore, and then it does not work ! He would loose all funds ! This issue should get a "severe bug" label to start with ! Ideally there would be a warning on the affected version(s) and even shared (at lest) on twitter and discord !

xendarboh commented 1 year ago

Thanks, I look forward to the next version. Happy to test. It's possible that this issue and #25 are expressions of the same bug, a 30s expiration. The wallet is unusable as it is and I'm looking at downgrading the extension until resolved.

wjdfx commented 1 year ago

@wjdfx This is a SEVERE problem ! What if somebody saves the wrong seed words, has to restore, and then it does not work ! He would loose all funds ! This issue should get a "severe bug" label to start with ! Ideally there would be a warning on the affected version(s) and even shared (at lest) on twitter and discord !

Don't FUD. Users won't save wrong mnemonic phrase. If the user has not successfully recorded their mnemonic phrase for a period of time, they failed verification and will not even succeed in creating the wallet.

wjdfx commented 1 year ago

Thanks, I look forward to the next version. Happy to test. It's possible that this issue and #25 are expressions of the same bug, a 30s expiration. The wallet is unusable as it is and I'm looking at downgrading the extension until resolved.

@xendarboh Thanks for you feedback again. Prior to this, we realized that this was a Keep alive issue with Chrome Manifest V3. This problem can be reproduced on some specific pages (especially when they no longer communicate with the backend Service Worker for a long time). The problem has been fixed in 6e5d2c9f89b42ebfe7c211d79db8182597c11d85. Live version is v2.2.2.

In order to express our gratitude to you, please leave your Mina address(if you don't want public it, please add me in discord, my handle is @niu8 ).