search

auru / unity-cache

Cache abstraction around localforage
0 stars 2 forks source link

refactor(core): Rewrite cache on Dexie #10

Closed ya-woodcutter closed 7 years ago

ya-woodcutter commented 7 years ago

@TimeRaider @evilj0e @Blackheart340

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-19.2%) to 80.769% when pulling c5b2c7616dc3574f3cf562d58879dff7d6b62888 on ya-woodcutter:rewrite-dexie into b84fd1c5fdd76e4c3a69600e7b7e3d53c781b44a on auru:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-19.2%) to 80.769% when pulling c5b2c7616dc3574f3cf562d58879dff7d6b62888 on ya-woodcutter:rewrite-dexie into b84fd1c5fdd76e4c3a69600e7b7e3d53c781b44a on auru:master.

TimeRaider commented 7 years ago

please add test coverage

TimeRaider commented 7 years ago

if you guys need to release that ASAP, i suggest you make a seperate branch named next and publish npm module with @next tag. This article explains why it's a good idea to publish pre-lease code under @next tag

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-2.08%) to 97.917% when pulling 8c57a2f4aaa7086e1f8118fbc920f39e0b4e3269 on ya-woodcutter:rewrite-dexie into b84fd1c5fdd76e4c3a69600e7b7e3d53c781b44a on auru:master.

Blackheart340 commented 7 years ago

LGTM 👍

TimeRaider commented 7 years ago

I dug deeper into Dexie's docs and the lib looks very powerful, so I'm all for switching to it instead of localforage. Since unity-cache's api hasn't changed, do we bump the minor version only? Are there any shortcomings in current api, maybe i should be reworked as well? in that case we'll bump the major version. Tell me what you think ... and awesome job, btw 👍 😄

ya-woodcutter commented 7 years ago

... Since unity-cache's api hasn't changed ... Not exactly... we changed cacheCreate function (-description, +version).

I think we need bump the major version. And the saying goes, go majornaya versia ya sozdal ... but first, I need to fix coverage.

TimeRaider commented 7 years ago

@ya-woodcutter ok then, cool

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 826ca7cfbc5a9b2c759030afe5deb5c42d8125ff on ya-woodcutter:rewrite-dexie into 5401fc2a070c68d9c7e763c42cceecba946ee7a6 on auru:master.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 4cc5862cc690b415e878924c436a9466f647c587 on ya-woodcutter:rewrite-dexie into 5401fc2a070c68d9c7e763c42cceecba946ee7a6 on auru:master.

ya-woodcutter commented 7 years ago

REVIEW: @TimeRaider @Blackheart340 @evilj0e I pushed the commit in upstream/rewrite-dexie :)

TimeRaider commented 7 years ago

@ya-woodcutter thanks! I'll play around with it this weekend

Blackheart340 commented 7 years ago

@TimeRaider Looks like you forgot about it. We discussed and thought it would be perfect if we'll get new version. So... don't be shy, just merge and release it :)