search

aurzenligl / prophy

prophy: fast serialization protocol
MIT License
13 stars 8 forks source link

ISAR's unicode bug #28

Closed kamichal closed 5 years ago

kamichal commented 5 years ago

Im' sorry. Unexpected thing happened.

I added possibility to open any source files encoded with utf-8 in prophy v 1.2.0 and it's nice (at least in my opinion), but I missed the fact that xml.ElementTree needs to get encoded strings and fails otherwise.

The fix is very simple - just to encode the source back to raw utf-8 before parsing by ISAR. Other parsers gets soft unicode strings. Thanks to that FileProcessor doesn't have to make any exceptions in encoding format regarding target parser (never did so far and still doesn't have to).

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.0001%) to 99.599% when pulling 1d6399a1a48af42d97ce7221e06aca0508d410a6 on isar_unicode_fix into 61065d5efee6ead0b0714944b9fb916eedddc7e5 on master.