search

ausaccessfed / aaf-shib-ext

Shibboleth extension for auEduPersonSharedToken
Apache License 2.0
0 stars 0 forks source link

Feature/add primary key name param #10

Closed trsau closed 7 years ago

trsau commented 7 years ago

Build for IdP using ORACLE DB rather than MySQL. Tested against a test ORACLE DB and in use at UoN as part of their IdP upgrade.

A compiled version of the .jar file needs to added to S3 as /aaf-binaries/jar/aaf_shib_ext/aaf-shib-ext-1.1.0.jar

Needs a new tag of 1.1.0

solve #9

smangelsdorf commented 7 years ago

Adding @rianniello as an additional reviewer, to rule out impact on Hosted IdP (and for more :eyes: on the code)

rianniello commented 7 years ago

Hm, the build is breaking on codeship as it has been configured to use a gradle wrapper ( https://github.com/ausaccessfed/aaf-shib-ext/pull/12). I guess we can verify the build manually for this PR.

Getting some checkstyle failures:

$ gradle clean build
:clean
:compileJava
Download https://jcenter.bintray.com/net/shibboleth/utilities/java-support/7.2.0/java-support-7.2.0.pom
Download https://jcenter.bintray.com/org/springframework/spring-webmvc/4.2.0.RELEASE/spring-webmvc-4.2.0.RELEASE.pom
Download https://jcenter.bintray.com/org/springframework/spring-webmvc/4.2.0.RELEASE/spring-webmvc-4.2.0.RELEASE.jar
:processResources
:classes
:jar
:assemble
:checkstyleMain
[ant:checkstyle] /Users/rianniello/Projects/aaf-shib-ext/src/main/java/au/edu/aaf/shibext/sharedtoken/dataconnector/SharedTokenDataConnector.java:122: Line is longer than 120 characters (found 141).
:checkstyleMain FAILED
:checkstyleMainHtml

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at: file:///Users/rianniello/Projects/aaf-shib-ext/build/reports/checkstyle/main.html

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

BUILD FAILED
rianniello commented 7 years ago

Aside from https://github.com/ausaccessfed/aaf-shib-ext/pull/10#issuecomment-289652060, this PR is looking fine for a merge. 👍

trsau commented 7 years ago

Style issue resolved. This highlighted a change to two exception messages causing two failure test. These have also been resolved and all test currently pass.