BUG - WHEN ADDING A 0 IN PORTFOLIO AMOUNT

ausangshukla / xirr_py

Rest service for computing XIRR using python pandas and scikit

0 stars 0 forks source link

BUG - WHEN ADDING A 0 IN PORTFOLIO AMOUNT #16

Open aseemkarmali opened 2 months ago

aseemkarmali commented 2 months ago

It does not create a PI but creates an API - lets put a validation that portfolio amount has to be greater than 0

shrikantgour commented 2 months ago

creation with amount 0 is still allowed as that can happen internally and we dont want to get an error in that. when Pi creation fails API and valuation will not be created/updated

shrikantgour commented 2 months ago

can no longer create Pi with 0 amount internal updates will work